Improve processing of truncated GIFs#234
Merged
Merged
Conversation
This commit adds a dedicated error variant for truncation and ensures that the unused part of the output buffer is zeroed. This allows users to display incomplete images, matching the functionality of giflib.
kornelski
approved these changes
Apr 28, 2026
197g
requested changes
Apr 28, 2026
Member
197g
left a comment
197g
left a comment
There was a problem hiding this comment.
I do like the approach, zeroing explicitly is easiest to adjust later if we'd want to offer other fill (opaque black) or even just record the ranges that were affect. LGTM except the internal API nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a dedicated error variant for truncation and ensures that the
unused part of the output buffer is zeroed. This allows users to explicitly handle
truncation and still display the image if desired.
Thank you for your fantastic work on image-gif! 😃